Adjustments/messaging #1061
Merged
Adjustments/messaging #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the messaging flow diagram to include error handling for adding participants. - Improved the events location selector flow diagram with clearer method labels. - Added new diagrams for platform manager functionalities: user administration, invitation system, user support, and security monitoring. - Created user authentication flow diagram to illustrate the sign-in process. - Refactored user management flow diagram to serve as an index linking to detailed sub-diagrams. - Introduced user profile management flow diagram to outline profile editing processes. - Implemented client-side validation for conversation creation to prevent empty messages. - Enhanced conversation factory to ensure initial messages are present for validation. - Added tests for conversation creation with initial messages and profile message prefill functionality. - Updated resource toolbar to support additional actions via block content.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
… persistence of core fields in controller specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to model attribute handling, controller parameter security, test configuration, and UI/UX for resource and conversation management. The main focus is on making attribute permission more maintainable and DRY, enhancing automated test setup, and improving the responsiveness and accessibility of shared UI components.
Model attribute permission and controller parameter security:
self.permitted_attributeson models, allowing controllers to use model-defined permit lists instead of hard-coding them. Nested attributes are composed by referencing other models’permitted_attributes. [1] [2]conversations_controller.rb,messages_controller.rb,navigation_areas_controller.rb, andnavigation_items_controller.rbto use model-definedpermitted_attributesfor strong parameters, improving maintainability and consistency. [1] [2] [3] [4]Automatic test configuration and authentication helpers:
configure_host_platform, streamlining test writing and reducing boilerplate. [1] [2]UI/UX improvements for resource toolbar and conversation header:
.resource-toolbarand.resource-toolbar-extrato improve layout and spacing for shared resource actions, and imported these styles in the main stylesheet. [1] [2]Form label accessibility and validation:
required_labelhelper to support label text overrides and provide a tooltip for the required field indicator, improving accessibility and mobile usability.Conversation creation and participant management:
add_participant_safe. [1] [2]Let me know if you want to dive deeper into any specific change!